You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Generate third-party notices from the build (UNI-33) - #5805
UNI-33 / PI-831: UniGetUI now ships a THIRD-PARTY-NOTICES.txt (and .json) generated from what each build actually ships, in the format shared across Devolutions products, and the About page reads it instead of a hand-maintained list.
Generation
scripts/third-party-licenses/ is a copy of RDM's DevTools/ThirdPartyLicenses (commit 4020053), so our public CI does not depend on the private RDM repository. Scripts and template are unchanged; config/ holds UniGetUI's entries only. See its README.
scripts/generate-third-party-notices.ps1 reads UniGetUI.deps.json from the build folder (a NativeAOT publish folder has none) and the native files from the publish folder.
Declared by hand, since no build output describes them: the Inter font, the Icons8 icons, and on Windows the signature-check DLL, the WinGet COM metadata, Inno Setup and InnoDependencyInstaller (our 2024 copy predates its CPOL → MIT relicense). Skia/HarfBuzz native packages carry the notices of the libraries compiled into them; the Windows SDK projection gets the SDK license terms.
pinget's Rust crates (262): pinget does not commit its Cargo.lock, so Update-PingetCrates.ps1 resolves the v0.13.0 tag as crates.io stood at the tag's time and checks the result against the crate versions embedded in the shipped pinget.exe (127/127 match). Bumping Devolutions.Pinget.Cli.Rust without re-running it fails the release.
Release pipeline (build-release.yml)
Every runtime generates its own notices next to the binaries. License findings don't stop the release (PI-831 leaves enforcing an approved-license list out of scope); a missing file does.
After a stable, non-dry-run release, commit-third-party-notices opens a PR with the win-x64 copy into src/UniGetUI.Avalonia/ThirdPartyNotices/only when a component changed. It uses DEVOLUTIONSBOT_TOKEN so the PR runs CI. Dev builds ship that copy.
Publish and size-report now download UniGetUI-* artifacts only, so the notices artifact isn't attached to the release.
In the app
About → Third-party licenses lists every component (name, version, license, source link), shows each license text on demand, and opens the full file. The TUI About dialog lists the same data.
LicenseData (Licenses.cs) and the separate Licenses/Tomlyn.txt are removed.
Licenses outside the allow-list (informational)
Reported by the tool, written into the notices with their full text, not blocking: Windows SDK, Inter (OFL-1.1), Icons8, Inno Setup, InnoDependencyInstaller (CPOL-1.02), and in pinget's crates Unicode-3.0, MPL-2.0, MIT-0, CC0-1.0/MIT-0, bzip2-1.0.6.
PI-831 asks every Devolutions product to ship a THIRD-PARTY-NOTICES.txt generated
from what the build actually ships, in one shared format, with an in-product view
for apps with a UI and a copy pushed back to the repository.
Generation
- scripts/third-party-licenses is a copy of RDM's DevTools/ThirdPartyLicenses
(commit 4020053), so UniGetUI's public CI does not depend on the private RDM
repository. Its scripts and template are unchanged; config/ holds UniGetUI's
own entries only. The RDM-specific SixLabors.ImageSharp test is removed.
- scripts/generate-third-party-notices.ps1 reads UniGetUI.deps.json from the
build folder, because a NativeAOT publish folder has none, and the shipped
native files from the publish folder. It deletes any notices file in the
output folder first, so a run that fails early never leaves the committed
copy behind for a release to ship.
- Content no build output describes is declared by hand: the Inter font
(OFL-1.1), the Icons8 icons, and on Windows the signature-check DLL
(byte-identical to Microsoft.Security.Extensions 1.4.0), the WinGet COM
metadata, Inno Setup and InnoDependencyInstaller. Our copy of the latter
dates from 2024, before its relicense from CPOL to MIT, so it is listed
under CPOL 1.02.
- The Skia and HarfBuzz native packages carry the notices of the libraries
compiled into them; the Windows SDK projection gets the SDK license terms.
pinget's Rust crates
- pinget does not commit its Cargo.lock, so Update-PingetCrates.ps1 resolves
the v<version> tag as crates.io stood at the tag's time and refuses the
result unless every crate version found in the shipped pinget.exe is in it.
For 0.13.0 all 127 match. License texts come from each crate's package.
- The wrapper refuses a crate list made for another pinget version, so a
pinget bump cannot ship stale attributions.
Release pipeline
- Every runtime generates its own notices next to the binaries. The step may
fail on license findings without stopping the release (PI-831 leaves
enforcing an approved-license list out of scope); a missing file does.
- After a stable release, a job opens a pull request with the win-x64 copy
when a component changed. It uses DEVOLUTIONSBOT_TOKEN because pull requests
opened with GITHUB_TOKEN never run CI, and a re-run reuses the branch and
pull request. Publish and size-report download only UniGetUI-* artifacts so
the notices artifact is not attached to the release.
In the app
- The About page and the TUI About dialog read the bundled JSON through
ThirdPartyNotices (source-generated JSON, NativeAOT-safe) instead of the
hand-maintained, outdated LicenseData list. The About page lists name,
version, license and source, shows each license text on demand and opens
the full file. Licenses/Tomlyn.txt is no longer shipped separately.
Verified with a local NativeAOT win-x64 publish run through the CI steps:
both files are written (320 components) and pass the integrity tree check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The exclusion list omits the repository-built UniGetUIMacNotificationBridge.dylib, causing both macOS releases to misidentify it as a third-party component with missing license, source, and version metadata.
This PR replaces UniGetUI’s hand-maintained license list with build-generated third-party notices, shared by release packages and the graphical and terminal About views.
Changes:
Adds notice-generation tooling, component metadata, license texts, and regression tests.
Integrates per-runtime generation and stable-release notice update PRs into the release workflow.
Updates About views to display generated components and open the full notices file.
UniGetUIMacNotificationBridge.dylib is built from scripts/macos by a
post-publish target, so no deps.json lists it, and a .dylib carries no
version resource to name Devolutions as its company. The notices tool
therefore reported it on both macOS builds as an unknown third-party binary
with no license, source or version. Exclusions are matched against the
binary's base name, hence the entry without the extension.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The notices glob matches no files, so removing the existing license data leaves clean development builds and publishes outside build-release.yml without third-party notices and both About views showing a missing-notices message.
This glob currently matches no files: src/UniGetUI.Avalonia/ThirdPartyNotices/ contains neither notices file. Since this PR also removes LicenseData and the separately shipped Tomlyn license, a clean development build or a publish outside build-release.yml now has no third-party notices at all, and both About views show only the missing-notices message. Please bootstrap the checked-in pair from CI before removing the old data, or generate the files for these build paths rather than relying on a follow-up PR after the first stable release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNI-33 / PI-831: UniGetUI now ships a
THIRD-PARTY-NOTICES.txt(and.json) generated from what each build actually ships, in the format shared across Devolutions products, and the About page reads it instead of a hand-maintained list.Generation
scripts/third-party-licenses/is a copy of RDM'sDevTools/ThirdPartyLicenses(commit4020053), so our public CI does not depend on the private RDM repository. Scripts and template are unchanged;config/holds UniGetUI's entries only. See its README.scripts/generate-third-party-notices.ps1readsUniGetUI.deps.jsonfrom the build folder (a NativeAOT publish folder has none) and the native files from the publish folder.Cargo.lock, soUpdate-PingetCrates.ps1resolves thev0.13.0tag as crates.io stood at the tag's time and checks the result against the crate versions embedded in the shippedpinget.exe(127/127 match). BumpingDevolutions.Pinget.Cli.Rustwithout re-running it fails the release.Release pipeline (
build-release.yml)commit-third-party-noticesopens a PR with the win-x64 copy intosrc/UniGetUI.Avalonia/ThirdPartyNotices/only when a component changed. It usesDEVOLUTIONSBOT_TOKENso the PR runs CI. Dev builds ship that copy.UniGetUI-*artifacts only, so the notices artifact isn't attached to the release.In the app
LicenseData(Licenses.cs) and the separateLicenses/Tomlyn.txtare removed.Licenses outside the allow-list (informational)
Reported by the tool, written into the notices with their full text, not blocking: Windows SDK, Inter (OFL-1.1), Icons8, Inno Setup, InnoDependencyInstaller (CPOL-1.02), and in pinget's crates Unicode-3.0, MPL-2.0, MIT-0, CC0-1.0/MIT-0, bzip2-1.0.6.
Test plan
ThirdPartyNoticesTests(4),ThirdPartyLicensesViewModelTests(8), TUIAbout_ListsThirdPartyComponents_AndOpensTheNoticesFile; TUI shell tests passdotnet format whitespaceandstylegates