Repository navigation
FIX: reject a stale cursor in the target, technique, and initializer registries - #4530
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4525
The target, technique, and initializer list endpoints now reject a cursor naming an entry that no longer exists, raising the same ValueError the scorer registry raises (mapped to 400 by the shared handler), instead of silently restarting at the first page and serving duplicate rows to a paging client. The technique test that pinned the restart by name predates the scorer fix and is updated to the explicit contract with a note.
Tests and Documentation
Three regressions, one per service, each paging with a cursor naming an unregistered entry and asserting the rejection; all fail on main, which serves the first page again. The target, technique, and initializer suites pass at 277 tests and ruff check and format are clean.
No documentation change needed, so I did not run JupyText.