Repository navigation
FIX: strip the expected value in StartsWith under ignore_whitespace - #4534
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4529
StartsWith under ignore_whitespace now strips the expected value like Equals already does, so the flag means one thing across the literal matcher family and a criterion that only carries incidental surrounding whitespace can match instead of silently degrading to a permanent False verdict. Case sensitivity and ignore_whitespace false behavior are unchanged.
Tests and Documentation
The matcher table gains the padded value rows, and the previously pinned row that codified the asymmetry (a whitespace padded StartsWith value on padded text) now expects the same answer Equals gives. The new rows fail on main. The output matches scorer suite passes at 45 tests, the full score tree passes apart from four preexisting dispatch exhaustiveness failures that fail identically on main, and ruff check and format are clean.
No documentation change needed, so I did not run JupyText.