Repository navigation
Conversation
|
Independent Linux CMP 170HX / SM80 validation of
Native command: Commands, unchanged fixture, logs, source hashes and guard summary. The first session passed all candidate tests; a runner permission error before the control was corrected, and a fresh session ran only the control. Both outcomes are retained. No audio/model download, transcription or performance claim. This automated validation used Codex assistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
median_filter_cudabuilds a contiguous copy to derive its output layout, but launches the Triton kernel with the original input. The kernel assumes contiguous rows and adjacent values along the last dimension, so channels-last or transposed inputs can produce incorrect medians and can cause reads beyond the input view's logical storage.Keep the existing contiguous copy and pass it to the kernel. Contiguous inputs remain a no-op for
contiguous(), and non-contiguous inputs are copied once as before.The new regression covers channels-last and transposed inputs, float16 and float32, and filter widths 3, 7, and 13. It uses an oversized backing allocation to reproduce the incorrect addressing without reading outside the test's owned allocation.
Validation:
pytest -q tests/test_timing.py.median_filtercomparisons passed for channels-last and contiguous 3D inputs.git diff --checkpassed.These are component tests; no full-model transcription or performance claim is made.