Skip to content

session_destroy() / session_abort() from __serialize() causes NULL dereference in ps_files_open #25644

Open

Description

@lenulk

Description

Summary

Calling session_destroy(), session_abort(), or session_write_close() from
inside a session object's __serialize() re-enters the session module while it
is still encoding $_SESSION. For the files handler this ends in a NULL
dereference in ps_files_open() (ext/session/mod_files.c:157), because
PS(mod_data) has already been closed by the re-entrant call while
php_session_save_current_state() still calls s_write() afterwards.

On Windows the process exits with 0xC0000005 (STATUS_ACCESS_VIOLATION); on
Linux the ASAN build reports a SEGV in ps_files_open.

Affected

  • PHP 8.6.0 NTS x64/x86 (Windows), PHP 8.5.13, PHP 8.4.28
  • PHP 8.6.0 NTS DEBUG + ASAN/UBSAN (Linux, WSL)
  • session.serialize_handler=php (also reproduced with php_binary and
    php_serialize in the harness)

Reproducer

<?php
class Boom {
    public $a = 1;
    public function __serialize(): array {
        session_destroy();          // or session_abort(); or session_write_close();
        return ['a' => $this->a];
    }
}
session_start();
$_SESSION['s'] = new Boom();
session_write_close();              // crash here, or at RSHUTDOWN without this line

Run with a writable session.save_path, session.use_cookies=0:

php -d session.save_path=/tmp/sessdir -d session.use_cookies=0 \
    -d session.serialize_handler=php repro.php

Minimal harness used for matrix testing (one op per process):

python harnesses/run_one.py --php bin/php86-x64/php.exe --ini env/ini/php86-x64.ini \
  --script parallel/chats/chat-02-session/harness/mini2.php \
  --arg destroy --arg php --arg 0 --arg /tmp/sessdir --arg c2ro000000000000000000004 \
  --log parallel/chats/chat-02-session/crashes/sess-reentry.jsonl --tag reenter-destroy

Control: --arg none exits 0.

Expected / actual

  • Expected: either the re-entrant call is rejected with a warning/Error, or it
    completes without corrupting module state. __serialize() is documented as
    user code that runs during serialization, so re-entrancy is reachable.
  • Actual: SEGV / access violation at shutdown; no diagnostic.

ASAN trace (PHP 8.6.0 DEBUG + ASAN/UBSAN, Linux)

ext/session/mod_files.c:157:10: runtime error: member access within null pointer of type 'struct ps_files'
AddressSanitizer: SEGV on unknown address 0x000000000024 ... in ps_files_open
  #0 ps_files_open                     ext/session/mod_files.c:157
  #1 ps_files_write                    ext/session/mod_files.c:231
  #2 ps_write_files                    ext/session/mod_files.c:561
  #3 php_session_save_current_state    ext/session/session.c:561
  #4 php_session_flush                 ext/session/session.c:1840
  #5 zif_session_write_close           ext/session/session.c:2835

session_abort() with a user save handler also shows the semantic bug without
a crash: H_CLOSE is followed by H_WRITE len=31 (write after abort). The
$_SESSION UAF claim is source-based; ASAN did not observe it in these runs.

Suggested fix

At minimum, make php_session_save_current_state() re-check the handler/data
after php_session_encode() returns, and make ps_files_open() tolerate a
NULL ps_files (return FAILURE instead of dereferencing). A stricter fix is
to reject session API re-entrancy while PS(in_save_handler)/encoding is
active (fatal Error or warning), which matches the module's existing
re-entrancy guards elsewhere.

Notes

  • This report is intentionally separate from the security advisories; the
    trigger requires application code to call the session API from __serialize().
  • Raw logs: work/wsl/asan-sess-destroy.log, asan-sess-abort.log,
    asan-sess-writeclose.log; Windows matrix: parallel/chats/chat-02-session/crashes/sess-reentry.jsonl.
  • Reporter: Leenulk Jantarangsee (lenulkjantarangsee@gmail.com)

PHP Version

PHP 8.6.0 (cli) (built: Nov 19 2026 15:17:27) (ZTS)
Copyright © The PHP Group and Contributors
Built by Ubuntu
Zend Engine v4.6.0, Copyright © Zend by Perforce
    with Zend OPcache v8.6.0, Copyright ©, by Zend by Perforce

Operating System

Windows 11 / Ubuntu 26.04 (WSL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions