Repository navigation
Conversation
Keep the range warning for a final IPv4 part that spans multiple octets. Classify it while parsing the host so a later port failure does not change its severity. Reported by M4kuq.
TimWolla
requested changes
Nov 20, 2026
Member
There was a problem hiding this comment.
Functional changes to Lexbor need to first be accepted upstream at https://github.com/lexbor/lexbor/pulls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25604. Thanks to @M4kuq for reporting and diagnosing the issue.
PHP accepts
http://2130706433/and normalizes its host to127.0.0.1,but marks the IPv4 range warning as fatal. This change preserves the
warning and sets
failuretofalsewhen the final IPv4 part fits inthe remaining octets. Genuine overflows still fail.
The regression test also covers a valid integer host followed by an
invalid port, so each diagnostic retains the correct severity.
Tested on PHP 8.5.13. The regression test failed before the fix and
passed afterward. The URI suite had 330 passes, 6 skips, and 0 failures.