Repository navigation
Conversation
26 tasks
eendebakpt
reviewed
Nov 22, 2026
| .tp_basicsize = sizeof(PyPickleBufferObject), | ||
| .tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC, | ||
| .tp_new = picklebuf_new, | ||
| .tp_vectorcall = picklebuf_vectorcall, |
Contributor
There was a problem hiding this comment.
Why add vector all? Is the PickleBuffer used in performance critical code?
Contributor
Author
There was a problem hiding this comment.
It is listed as speedup candidate in #162350. Benchmark above shows good 1.6x enhancement. This enhancement is free, the only cost to get the benefit is a bit refactor of code to add vectorcall. I think we can do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-written
picklebuf_newwith Argument Clinic + vectorcall.Extra positional arguments now raise
TypeError: PickleBuffer expected 1 argument, got Ninstead ofTypeError: PickleBuffer() takes at most 1 argument (N given). Keyword arguments now raiseTypeError: PickleBuffer() takes no keyword argumentsinstead ofTypeError: PickleBuffer() takes exactly 1 positional argument (0 given).Benchmark:
Details